More explicitly list safe config changes to merge #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code review work is also work, and especially for a split TZ team like ours, latency here can be a real velocity killer. A lot of config changes only take a 'rubber stamp' approval, because someone still needs to verify that the change actually propagated. This PR more explicitly lists some of these config changes that don't need review, as there isn't any effective way for someone to really provide review here. This list will get bigger over time, and should give us more confidence to move faster.
consideRatio
approved these changes
Apr 20, 2024
sgibson91
approved these changes
Apr 22, 2024
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review work is also work, and especially for a split TZ team like ours, latency here can be a real velocity killer. A lot of config changes only take a 'rubber stamp' approval, because someone still needs to verify that the change actually propagated.
This PR more explicitly lists some of these config changes that don't need review, as there isn't any effective way for someone to really provide review here. This list will get bigger over time, and should give us more confidence to move faster.