Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensci, sciencecore: startup jupyterlab instead of classic UI by default #3954

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Apr 16, 2024

Is JupyterLab preferred over the classic UI view for the "Pangeo notebook image" and "Jupyter SciPy Notebook" image choices? This PR makes it so if approved.

Ping @kyttmacmanus and @jmunroe

Copy link

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws opensci No Yes Following prod hubs require redeploy: sciencecore

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws opensci sciencecore Following helm chart values files were modified: sciencecore.values.yaml

@yuvipanda
Copy link
Member

With #3972, this can be self merged

@consideRatio
Copy link
Member Author

Its not on request from the community though, its my own initiative thinking its desired on sciencecore

@kyttmacmanus
Copy link

I am sorry for the slow reply. My sciencecore project will use a mix of Jupyter and Quarto notebooks, but I am not sure what the other sciencecore projects are using. I personally do like the jupyterhub default view but would defer to @jmunroe on an answer to your question.

@jmunroe
Copy link
Contributor

jmunroe commented Apr 24, 2024

I agree that /lab is a better default for those images.

@consideRatio consideRatio merged commit 8dfd01e into 2i2c-org:main Apr 24, 2024
9 checks passed
@consideRatio
Copy link
Member Author

Thank you @kyttmacmanus and @jmunroe!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants