Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Azure OpenAI #1698

Merged
merged 6 commits into from
Mar 15, 2024
Merged

Add support for Azure OpenAI #1698

merged 6 commits into from
Mar 15, 2024

Conversation

olederle
Copy link
Contributor

Allows to use Azure OpenAI as LLM and embedding model.

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-2070757f-a2eb-4a3f-9ba7-cf21ab21280c.docs.buildwithfern.com

@olederle olederle marked this pull request as ready for review March 10, 2024 16:03
imartinez
imartinez previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@imartinez imartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! As an optional idea, I'd suggest to include this option in the installation docs, both in the list of available options to select and as a recommended setup. https://docs.privategpt.dev/installation/getting-started/installation

@imartinez
Copy link
Collaborator

@olederle please run make check and make test locally. Apparently there are some issues with make check that are preventing the merge.

@SeifBach
Copy link

hey guys just a heads up in the doc [fern/docs/pages/manual/llms.mdx] you guys wrote
api_version: <api_version> # The API version to use. Default is "2023_05_15"
when i tried it it gave me a 404 but worked with dashes instead of underscores 2023-05-15

@olederle
fix: wrong default api_version
71e44ce 
Should be dashes instead of underscores.
see: https://learn.microsoft.com/en-us/azure/ai-services/openai/reference
@olederle
fix: code styling
e3c0c7f 
applied "make check" changes
@olederle
refactor: extend documentation
2e63fe0 
* mention azopenai as available option and extras
* add recommended section
* include settings-azopenai.yaml configuration file
@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-31cfc7df-c2f0-4abf-b2ce-51708d09c395.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-bd8e80a7-86cd-4bbc-988f-be7da3cc9e2d.docs.buildwithfern.com

@github-actions GitHub Actions
Copy link
Contributor

Published docs preview URL: https://privategpt-preview-a3fbc74d-159d-471a-813a-61686c78614b.docs.buildwithfern.com

@olederle
Copy link
Contributor Author

hey guys just a heads up in the doc [fern/docs/pages/manual/llms.mdx] you guys wrote api_version: <api_version> # The API version to use. Default is "2023_05_15" when i tried it it gave me a 404 but worked with dashes instead of underscores 2023-05-15

That is right. For my use case I have used a preview api_version but want to have a stable version as default. But I introduced a typo with this. This is fixed now.

@olederle
Copy link
Contributor Author

@olederle please run make check and make test locally. Apparently there are some issues with make check that are preventing the merge.

@imartinez This should be fixed now and I have also updated the docs.

@imartinez imartinez merged commit 1efac6a into zylon-ai:main Mar 15, 2024
7 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imartinez imartinez imartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olederle @imartinez @SeifBach