Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New onboading pages #44

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

taiwonaf
Copy link
Contributor

@taiwonaf taiwonaf commented Mar 3, 2023

localhost_9000_signup-otp

Fixes Issue/Linear Ticket

This could be an existing issue or a linear ticket

  • Github Issue Example: My PR Closes #{ISSUE}
  • Linear Ticket Example: Fixes ID-#{ISSUE}

Changes proposed

Onboarding pages

Talk about the things you did eg. files changes, dependencies installed e.t.c

Check List (Check all the applicable boxes)

🚨Please review the style guide for contributing and guidelines for contributing to this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the main branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots/ Videos

localhost_9000_signup
localhost_9000_login
localhost_9000_signup-otp

Copy link
Contributor

@ickynavigator ickynavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have alternate pages for signup and otp?

Comment on lines +69 to +110
<NumberInput
hideControls
classNames={{ input: classes.input }}
h={45}
w={50}
maxLength={1}
/>
<NumberInput
hideControls
classNames={{ input: classes.input }}
h={45}
w={50}
maxLength={1}
/>
<NumberInput
hideControls
classNames={{ input: classes.input }}
h={45}
w={50}
maxLength={1}
/>
<NumberInput
hideControls
classNames={{ input: classes.input }}
h={45}
w={50}
maxLength={1}
/>
<NumberInput
hideControls
classNames={{ input: classes.input }}
h={45}
maxLength={1}
w={50}
/>
<NumberInput
hideControls
classNames={{ input: classes.input }}
h={45}
maxLength={1}
w={50}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number input doesn't store the value anywhere.

Also Mantine provides a pin input that you can use instead of recreating that design

<FormTitle
title="Verify your email address!"
subtitle="We have sent your code "
boldSubtitle={"[email protected]"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mail should not be hardcoded

bg={theme.colors.secondary[5]}
className={classes.continueBtn}
>
Continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the API is ready so this function should be connected properly


const useStyles = createStyles(theme => ({
formHeader: {
position: "fixed",
left: "0",
right: "0",
top: "0",
height: "75px",
borderBottom: "1px solid #F9DBB6",
// height: "75px",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Comment on lines +63 to +83
{
path: "alternative-signup",
element: <LoginWrapper />,
errorElement: <ErrorPage />,
children: [
{
index: true,
element: <AlternativeSignup />
}
]
},
{
path: "alternative-signup-otp",
element: <LoginWrapper />,
errorElement: <ErrorPage />,
children: [
{
index: true,
element: <AlternativeSignupOtp />
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have alternate pages?

size="md"
autoComplete="false"
classNames={{ input: classes.inputField }}
{...LoginForm.getInputProps("email")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you used the wrong get input props in the functions
update this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there an alternate signup page

Comment on lines +110 to +120
<Button
fullWidth
mt="xl"
size="md"
variant="outline"
disabled={true}
className={classes.outlineBtn}
leftIcon={<IconBrandGoogle size={14} />}
>
Login with Google
</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need the login with google button for now

Enter here
</Text>
<Flex gap={10} justify="space-between">
<NumberInput
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the pin input instead

Comment on lines +53 to +62
<Button
fullWidth
mt="xl"
size="md"
variant="outline"
disabled={true}
className={classes.outlineBtn}
leftIcon={<IconBrandGoogle size={14} />}
>
Login with Google
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove google signup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants