Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue WTO message on API Mediation Layer startup #3894

Merged
merged 12 commits into from
Oct 1, 2024

Conversation

balhar-jakub
Copy link
Member

Describe your pull request here:
One of the common requests is issuing the specific message when the API Mediation Layer properly starts in the Syslog. This article explains all the configuration and pieces needed to achieve this goal with the current functionality.

List the file(s) included in this PR:
wto-message-on-startup.md

After creating the PR, follow the instructions in the comments.

@balhar-jakub balhar-jakub added area: apiml This issue is related to Zowe API Mediation Layer release: V2 Zowe V2 content review: doc Needs review by Doc Squad member labels Sep 30, 2024
@balhar-jakub balhar-jakub self-assigned this Sep 30, 2024
Copy link

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

Copy link

github-actions bot commented Sep 30, 2024

@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 10:33 Inactive
Signed-off-by: Andrew Jandacek <[email protected]>
`2024-09-30 10:17:53.814 <ZWEAGW1:DiscoveryClient-InstanceInfoReplicator-%d:3335> jb892003 INFO ((o.z.a.g.c.GatewayHealthIndicator)) ZWEAM001I API Mediation Layer started`

2. Prepare custom logging configuration.
The current default logging implementation starts with information about the current time. This message content is unlike the message id which is typical in z/OS. To change this message behavior, configure the logging configuration. For details about how to configure API Mediation logging, see [Customizing Zowe API Mediation Layer logging](./configuration-logging.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the meaning of this and why this is essential information in the instructions. Can you please modify or explain the reason this information is useful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The article is more of a use case and how to achieve this. This part explains how to provide the custom configuration in general.

The article below explains how does it need to look like for this specific requirements e.g. Syslog message issued with message id in the beginning.


2. Prepare custom logging configuration.
The current default logging implementation starts with information about the current time. This message content is unlike the message id which is typical in z/OS. To change this message behavior, configure the logging configuration. For details about how to configure API Mediation logging, see [Customizing Zowe API Mediation Layer logging](./configuration-logging.md).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide a single line description of what this configuration is? Is this an example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to change it.

</root>
</configuration>
```
3. Change the structure of the log messages for the Gateway within the API Mediation Layer:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what this change of structure achieves?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried in the change

Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 12:27 Inactive
Signed-off-by: Jakub Balhar <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request September 30, 2024 13:12 Inactive

This functionality requires the following changes to the zowe.yaml:

1. Change the property `zowe.sysMessages` by adding the value `- "ZWWEAM001I""`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZWWEAM001I -> ZWEAM001I

@1000TurquoisePogs
Copy link
Member

It looks like ZWEAM001I is a new message that is better than ZWEAM000I for detecting readiness. That's great!

Please see the PRs I made to implement this.
Also note, I do not see this message in v3, only in v2.
Since this is going into master, check to see if it will show up in v2.18 documentation, where it is appropriate, versus v3 documentation, where it appears to not exist yet.
If it is a v3.1 feature, perhaps docs-staging is more appropriate?

@balhar-jakub
Copy link
Member Author

It's been implemented only for V2 by now I believe. It should be in 2.x documentation.

As for v3 we originally intended something better, but it's probably good enough and we should bring it to the v3 as well at least.

Signed-off-by: Andrew Jandacek <[email protected]>

This functionality requires the following changes to the zowe.yaml:

1. Change the property `zowe.sysMessages` by adding the value `- "ZWEAM001I""`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be two quotation marks at the end of "ZWEAM001I""` ?

balhar-jakub and others added 4 commits October 1, 2024 11:28
Signed-off-by: Andrew Jandacek <[email protected]>
Signed-off-by: Andrew Jandacek <[email protected]>
Signed-off-by: Andrew Jandacek <[email protected]>
Copy link
Collaborator

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and edited by doc squad

@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 09:51 Inactive
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 1, 2024 11:24 Inactive
@janan07 janan07 merged commit b122a82 into master Oct 1, 2024
3 of 4 checks passed
@janan07 janan07 deleted the balhar-jakub/apiml/wto-message branch October 1, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: apiml This issue is related to Zowe API Mediation Layer release: V2 Zowe V2 content review: doc Needs review by Doc Squad member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants