adjust the judgment logic of calling UndoRecord interfacex #68
Conversation
…rd version. Now adjust to: checking whether the UndoRecord interface exists first, then decide to whether call the UndoRecord interface.
|
So generally we recommend posting to the zotero-dev mailing list if you want to make specific contributions to Zotero code. A good place to start is when coming up with fixes is with issues available on Zotero repos. As far as UndoRecord is concerned, since this code has been added, we have actually dropped support on Windows for Word versions earlier than 2010, so we could just drop the conditional. On the other hand, we generally don't fix what's not broken, including legacy handling code, because while we may not officially provide support and bugfixes for older versions of software, if users are able to get that to run and work on their machines, we're happy for them to do so. I assume you tested whether this works, but I'm not sure why this change is needed, aside from the fact that checking for functionality is generally the preferential way to build integrations as opposed to checking for version. Is there any specific reason why you think this change is necessary? |
In the past, whether to call the UndoRecord interface based on the word version. Now adjust to: checking whether the UndoRecord interface exists first, then decide to whether call the UndoRecord interface, this seems more safe and easier to understand.