Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection remove downloads action #983

Merged

Conversation

mvasilak
Copy link
Contributor

@mvasilak mvasilak commented Jul 17, 2024

  • Adds Remove Downloads action in collection context menu, when the collection has items. Similar to Download Attachments action, it doesn't explicitely check if there are any attachments already downloaded, it just checks for collection items count. This action is placed 2nd in the menu, after Download Attachments. For Trash it is placed 1st, as non-destructive.
  • Adds Remove downloads for selected items action in items toolbar. To differentiate from Move selected items to trash the icon arrow.down.circle.dotted is used.

Perhaps we should consider using the same icon, either a system or a custom one, for all actions that remove downloads.
Additionally, since we allow to remove downloads for selected items, maybe we should also allow to download attachments for selected items? If the toolbar gets too populated though, maybe we should consider a more button that presents a menu with the additional actions.

Closes #981

@michalrentka
Copy link
Contributor

  • Adds Remove Downloads action in collection context menu, when the collection has items. Similar to Download Attachments action, it doesn't explicitely check if there are any attachments already downloaded, it just checks for collection items count. This action is placed 2nd in the menu, after Download Attachments. For Trash it is placed 1st, as non-destructive.
  • Adds Remove downloads for selected items action in items toolbar. To differentiate from Move selected items to trash the icon arrow.down.circle.dotted is used.

Perhaps we should consider using the same icon, either a system or a custom one, for all actions that remove downloads. Additionally, since allow to remove downloads for selected items, maybe we should also allow to download attachments for selected items? If the toolbar gets too populated though, maybe we should consider a more button that presents a menu with the additional actions.

Closes #981

I agree having 2 icons for "delete item" and "delete attachment" would be great.

I'd say download selected actions is unnecessary. It's simpler to just start tapping items you want downloaded. Most people will probably download the whole collection anyway. But removing attachments can benefit from this because currently you have to long press each attachment and then tap to delete it.

@dstillman
Copy link
Member

You're saying this adds an option to remove downloads for selected items without their being an option to download files for selected items? I don't think that makes sense. Managing storage is a much more advanced task than just wanting files available offline, and you can always purge all files or (after this) purge all files for a given collection. So I think we want to either add both as multi-select options or only the download option.

@mvasilak mvasilak merged commit a24d7f6 into zotero:master Jul 29, 2024
1 check passed
@mvasilak mvasilak deleted the add-collection-remove-downloads-action branch July 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Remove selected attachments
3 participants