Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed crash when searching for item keys #731

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fixed crash when searching for item keys #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Zotero/Models/Predicates.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,8 @@ extension NSPredicate {
private static func itemSearchSubpredicates(for text: String) -> NSPredicate {
let keyPredicate = NSPredicate(format: "key == %@", text)
let childrenKeyPredicate = NSPredicate(format: "any children.key == %@", text)
let childrenChildrenKeyPredicate = NSPredicate(format: "any children.children.key == %@", text)
// TODO: - ideally change back to "==" if Realm issue is fixed
let childrenChildrenKeyPredicate = NSPredicate(format: "any children.children.key contains %@", text)
let contentPredicate = NSPredicate(format: "htmlFreeContent contains[c] %@", text)
let childrenContentPredicate = NSPredicate(format: "any children.htmlFreeContent contains[c] %@", text)
let childrenChildrenContentPredicate = NSPredicate(format: "any children.children.htmlFreeContent contains[c] %@", text)
Expand Down