Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the xmltojson.py script #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve the xmltojson.py script #42

wants to merge 4 commits into from

Conversation

rudolfbyker
Copy link

  • Follow PEPs.
  • Clean up imports.
  • Separation of concerns and better code reuse by splitting up into functions.
  • Make silent by default, but add 'verbose' flag.
  • Use a context manager when writing a file, to prevent leaking file descriptors.

@rudolfbyker
Copy link
Author

@dstillman @northword would you prefer that I split this into smaller PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rudolfbyker