Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify error types and how to handle them. #27

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Simplify error types and how to handle them. #27

merged 5 commits into from
Jul 9, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Jul 9, 2024

No description provided.

@zoj613 zoj613 added storage related to storage refactoring labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 24 lines in your changes missing coverage. Please review.

Project coverage is 94.82%. Comparing base (fd68743) to head (d3eee09).

Files Patch % Lines
lib/storage/storage_intf.ml 0.00% 17 Missing ⚠️
lib/storage/storage.ml 66.66% 5 Missing ⚠️
lib/metadata.ml 75.00% 1 Missing ⚠️
lib/node.ml 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   94.78%   94.82%   +0.03%     
==========================================
  Files          13       13              
  Lines        1094     1082      -12     
==========================================
- Hits         1037     1026      -11     
+ Misses         57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 merged commit aa31327 into main Jul 9, 2024
3 of 4 checks passed
@zoj613 zoj613 deleted the poly branch July 9, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring storage related to storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant