Implementing flick action in ajio mobile #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbagmar
reviewed
Jul 7, 2023
snehith07
reviewed
Jul 7, 2023
src/test/java/com/znsio/teswiz/screen/android/ajio/SearchScreenAndroid.java
Outdated
Show resolved
Hide resolved
snehith07
reviewed
Jul 7, 2023
| driver.waitTillElementIsPresent(By.id("com.ril.ajio:id/layout_category_container")).click(); | ||
| public ProductScreen selectProduct() { | ||
| LOGGER.info("Selection of Product in the result page"); | ||
| if (!(driver.isElementPresent(byProductLayoutId))) { |
There was a problem hiding this comment.
do we need extra braces in if condition?
if(!driver.isElementPresent(byProductLayoutId))
There was a problem hiding this comment.
yes - when we land on the AJIO app on the first time - few sections got highlighted - and web elements are present below these elements
snehith07
reviewed
Jul 7, 2023
| @@ -15,6 +16,8 @@ public class SearchScreenAndroid | |||
| private static final Logger LOGGER = Logger.getLogger(SCREEN_NAME); | |||
| private static final By byResultsId = By.id("com.ril.ajio:id/tv_count_plp_header_is"); | |||
| private static final By byProductId = By.id("com.ril.ajio:id/plp_row_product_iv"); | |||
| private static final By byProductListTitleId = By.id("com.ril.ajio:id/toolbar_title_tv"); | |||
| public static final By byProductLayoutId = By.id("com.ril.ajio:id/layout_category_container"); | |||
There was a problem hiding this comment.
public variable?
are you using this VAR in another class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented flick action gesture in ajio mobile.