Horizontal swipe with gesture Plugin #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_gesture # Conflicts: # src/main/java/com/znsio/teswiz/runner/Driver.java
Darshan3S
changed the title
src/test/java/com/znsio/teswiz/screen/android/jiocinema/JioCinemaScreenAndroid.java
Outdated
Show resolved
Hide resolved
snehith07
reviewed
Jul 7, 2023
src/test/java/com/znsio/teswiz/screen/android/jiocinema/JioCinemaScreenAndroid.java
Outdated
Show resolved
Hide resolved
snehith07
reviewed
Jul 7, 2023
…th_gesture # Conflicts: # src/main/java/com/znsio/teswiz/runner/Driver.java
anandbagmar
reviewed
Jul 7, 2023
| @@ -40,4 +40,9 @@ public void iSwipeLeftOnTrendingInIndiaSection() { | |||
| public void iAmAbleToViewNumberTrendingCinema(int movieNumberOnScreen) { | |||
| new JioCinemaBL(SAMPLE_TEST_CONTEXT.ME, Runner.getPlatform()).verifyMovieNumberVisibleOnScreen(movieNumberOnScreen); | |||
| } | |||
|
|
|||
| @When("I swipe {string} trending no {int} on trending in india section") | |||
| public void iSwipeRightTrendingNoOnTrendingInIndiaSection(String direction, int movieNumberOnScreen) { | |||
There was a problem hiding this comment.
method name has "right" in it, where as the direction is a parameter
There was a problem hiding this comment.
Updated the method name
|
|
||
| @When("I swipe {string} trending no {int} on trending in india section") | ||
| public void iSwipeRightTrendingNoOnTrendingInIndiaSection(String direction, int movieNumberOnScreen) { | ||
| new JioCinemaBL(SAMPLE_TEST_CONTEXT.ME, Runner.getPlatform()).swipeMovieTrendingInIndiaSection(direction,movieNumberOnScreen); |
There was a problem hiding this comment.
instead of passing the direction as a string, convert it to the Direction enum here itself, and pass that as a parameter - Direction.valueOf(direction.toUpperCase()
See this implementation in AutoScrollSteps.java - iShouldBeAbleToScrollInDynamicLayer
There was a problem hiding this comment.
Updated with Direction object in method parameters
anandbagmar
reviewed
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers implementation for Horizontal swipe action using gesture plugin in teswiz framework