[Zomato assignement] Book a Table functionality on getting started with teswiz #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamaUgale
reviewed
Jun 16, 2023
| # CONFIG=./configs/zomato_local_config.properties TAG="@zomato" PLATFORM=web ./gradlew run | ||
| @web @single-user | ||
| Scenario: User should be able to book a table | ||
| Given I, as a user should be on the zomato home page and able to select the "NCR" location |
There was a problem hiding this comment.
Given I, as a User have set the location to "NCR" on the home page
| @Given("I, as a user should be on the zomato home page and able to select the {string} location") | ||
| public void iAsAUserShouldBeOnTheZomatoHomePageAndAbleToSelectTheLocation(String cityName) { | ||
| LOGGER.info(String.format( | ||
| "iAsAUserShouldBeOnTheZomatoHomePageAndAbleToSelectTheLocation - Persona:'%s', Platform: '%s'", |
There was a problem hiding this comment.
refactor method name according to the below comment on feature file
| "iAsAUserShouldBeOnTheZomatoHomePageAndAbleToSelectTheLocation - Persona:'%s', Platform: '%s'", | ||
| SAMPLE_TEST_CONTEXT.ME, Runner.getPlatform())); | ||
| Drivers.createDriverFor(SAMPLE_TEST_CONTEXT.ME, Runner.getPlatform(), context); | ||
| new ZomatoBL(SAMPLE_TEST_CONTEXT.ME, Runner.getPlatform()).selectDiningLocation(cityName); |
There was a problem hiding this comment.
rename ZomatoBL to ZomatoHomePageBL
|
|
||
| @Then("I am able to view login option") | ||
| public void iAmAbleToViewLoginOption() { | ||
| new ZomatoBL(SAMPLE_TEST_CONTEXT.ME, Runner.getPlatform()).verifyLoginOption(); |
There was a problem hiding this comment.
rename verifyLoginOption() to LoginPopUpWindow()
| private static final Logger LOGGER = Logger.getLogger(SCREEN_NAME); | ||
| private final Driver driver; | ||
| private final Visual visually; | ||
| private final By byRestaurantNameXpath = By.xpath("((//img[@alt='Restaurant Card'])[3]//following::h4)[1]"); |
| @Override | ||
| public DiningOutScreen selectDineOutOption() { | ||
| driver.waitTillElementIsVisible(byDineOutXpath); | ||
| driver.findElement(byDineOutXpath).click(); |
| public ZomatoBL bookATable(int guestCount, int aheadDays) { | ||
| LOGGER.info(String.format("bookATable(): book a table with %d number of guest and %d days ahead date", guestCount, aheadDays)); | ||
|
|
||
| String restaurantName = DiningOutScreen.get().getRestaurantName(); |
|
|
||
| String restaurantName = DiningOutScreen.get().getRestaurantName(); | ||
|
|
||
| assertThat(DiningOutScreen.get().selectRestaurant().isRestaurantNameVisible(restaurantName)) |
There was a problem hiding this comment.
you can create variable for DiningOutScreen object and reuse it in the line no 55 and 57
|
|
||
| public ZomatoBL verifyLoginOption() { | ||
| LOGGER.info("verifyLoginOption(): verify login option"); | ||
| RestaurantDetailScreen.get().verifyLogin(); |
There was a problem hiding this comment.
should be part on ResturantDetailsBL
MedhaGupta-Ril
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Verify user can book a table on Zomato
Expectations: We expect the following outcome
-Local execution report for the working test
-ReportPortal report of your execution, if applicable