Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖼️ Journal: Entry#summary #10

Open
zspencer opened this issue Jan 29, 2024 · 0 comments
Open

🖼️ Journal: Entry#summary #10

zspencer opened this issue Jan 29, 2024 · 0 comments
Labels
🤖 domain model A word of power in our human/computer translation language

Comments

@zspencer
Copy link
Member

zspencer commented Jan 29, 2024

@zspencer zspencer mentioned this issue Jan 29, 2024
3 tasks
zspencer added a commit to zinc-collective/convene that referenced this issue Jan 29, 2024
- zinc-collective#8
- zinc-collective#10

When I started on this, I started with [changes to the data
layer], because that's where my brain tends to naturally start.

But when I wrote the [system test], I realized it was more of an
[`Entries#summary`].

So I am renaming from `Entries#description` to `Entries#summary`.

Thank you for coming to my TED Talk.

[`Entries#summary`]: zinc-collective#9
[system test]: zinc-collective#9
[changes to the data layer]: zinc-collective#8
zspencer added a commit that referenced this issue Jan 29, 2024
- #8
- #10

When I started on this, I started with [changes to the data
layer], because that's where my brain tends to naturally start.

But when I wrote the [system test], I realized it was more of an
[`Entries#summary`].

So I am renaming from `Entries#description` to `Entries#summary`.

Thank you for coming to my TED Talk.

[`Entries#summary`]: #9
[system test]: #9
[changes to the data layer]: #8
zspencer added a commit that referenced this issue Jan 29, 2024
- #10

What I'm driving towards here is similar to
zinc-collective#2055, where a
`Journal::Entry` has an affordance for being opinionated about how it's
represented when linked to in search engines or peer-to-peer sharing; as
well as short text for when there are a several on `Journal#show`.
zspencer added a commit that referenced this issue Jan 29, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit to zinc-collective/convene that referenced this issue Jan 29, 2024
- zinc-collective#2
- zinc-collective#10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Jan 29, 2024
- #10

What I'm driving towards here is similar to
zinc-collective#2055, where a
`Journal::Entry` has an affordance for being opinionated about how it's
represented when linked to in search engines or peer-to-peer sharing; as
well as short text for when there are a several on `Journal#show`.
zspencer added a commit that referenced this issue Jan 29, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Jan 29, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit that referenced this issue Jan 29, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
@zspencer zspencer added the 🤖 domain model A word of power in our human/computer translation language label Jan 31, 2024
zspencer added a commit that referenced this issue Feb 3, 2024
- #10

What I'm driving towards here is similar to
zinc-collective#2055, where a
`Journal::Entry` has an affordance for being opinionated about how it's
represented when linked to in search engines or peer-to-peer sharing; as
well as short text for when there are a several on `Journal#show`.
zspencer added a commit that referenced this issue Feb 3, 2024
- #10
- #2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.
zspencer added a commit that referenced this issue Feb 3, 2024
- #2
- #10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
zspencer added a commit to zinc-collective/convene that referenced this issue Feb 3, 2024
- When zinc-collective#2, add an zinc-collective#10 so we can eventually display it when zinc-collective#4


* 🧹🥗 `Journal`: Add `Entry#summary` field (#8)

- zinc-collective#10

What I'm driving towards here is similar to
#2055, where a
`Journal::Entry` has an affordance for being opinionated about how it's
represented when linked to in search engines or peer-to-peer sharing; as
well as short text for when there are a several on `Journal#show`.

* 🛠️ `Journal`: Test only the `Journal in CI

While working on
zinc-collective#11, I realized I
missed a piece of the refactor because I was leaning-on-ci as a way to
confirm that everything was working as expected.

Little did I know, CI was not working in this fork. Which makes sense,
because you don't want to automatically turn on all the Workflows when
you fork a project.

This adds a Github Workflow for testing *just* the `Journal`, which
should make detecting oopsie-daisys a bit easier for folks who are only
interested in working on the Journal.

* 🥗 `Journal`: Test adding `Entry#summary` when Writing `Entries`

- zinc-collective#10
- zinc-collective#2

This is a quick line-of-action end-to-end test for setting an `Entry#summary`.

* ✨ `Journal`: Save `Entry#summary` when Writing `Entries`

- zinc-collective#2
- zinc-collective#10

And just like that, there's a `Summary` field on the
`Journal::Entry#new` page!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 domain model A word of power in our human/computer translation language
Projects
None yet
Development

No branches or pull requests

1 participant