✨ Journal: Author provides Entry#summary
#2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
journal/entry-summaries
branch
from
e6aa446
to
06842f5
Compare
zspencer
changed the title
Journal: Add an Entry#summaryJournal: Author provides Entry#summary
zspencer
changed the title
Journal: Author provides Entry#summaryJournal: Author provides Entry#summary
rosschapman
reviewed
Feb 2, 2024
| - name: Run Tests | ||
| env: | ||
| HEADLESS: true | ||
| run: bundle exec rspec spec/furniture/journal |
There was a problem hiding this comment.
What about excluding these tests from .github/workflows/test-convene-web.yml?
There was a problem hiding this comment.
I have some Ideas re: how to refactor our CI to split things out; but I don't know enough about the Github Actions syntax to do it.
Ideally we would have:
- An Action that creates a Slug w/all the Dev + Test dependencies
- A set of Actions that execute the tests for each Gizmo
- An Action that executes the tests for the OS itself
That way as we add gizmos the total test suite time doesn't go up.
But I also think that's a thing to deal with on a different day; once we decide it's worth it.
rosschapman
approved these changes
Feb 2, 2024
- #10 What I'm driving towards here is similar to zinc-collective#2055, where a `Journal::Entry` has an affordance for being opinionated about how it's represented when linked to in search engines or peer-to-peer sharing; as well as short text for when there are a several on `Journal#show`.
While working on #11, I realized I missed a piece of the refactor because I was leaning-on-ci as a way to confirm that everything was working as expected. Little did I know, CI was not working in this fork. Which makes sense, because you don't want to automatically turn on all the Workflows when you fork a project. This adds a Github Workflow for testing *just* the `Journal`, which should make detecting oopsie-daisys a bit easier for folks who are only interested in working on the Journal.
zspencer
force-pushed
the
journal/entry-summaries
branch
from
d220461
to
48fe7ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Journal: WritingEntriesjournal#2, add an 🖼️Journal:Entry#summaryjournal#10 so we can eventually display it when 🥔✨Journal: BrowsingEntriesjournal#4After
Before