Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace metadata #72

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

mchtech
Copy link
Contributor

@mchtech mchtech commented Mar 8, 2024

What this PR does / why we need it:

metadata.namespace is missing in some templates.

this is needed for when helm is used purely as a templating tool,
since helm template does not add the namespace
helm/helm#3553

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

Welcome @mchtech! It looks like this is your first PR to zilliztech/milvus-helm 🎉

@haorenfsa
Copy link
Collaborator

Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.

@mergify mergify bot removed the ci-passed label Jul 11, 2024
@mchtech
Copy link
Contributor Author

mchtech commented Jul 11, 2024

Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.

branch synced.

@mergify mergify bot added the ci-passed label Jul 12, 2024
@haorenfsa
Copy link
Collaborator

haorenfsa commented Jul 17, 2024

@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!

@haorenfsa
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, mchtech

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Jul 17, 2024
@mchtech
Copy link
Contributor Author

mchtech commented Jul 17, 2024

@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!

branch synced.

@mergify mergify bot added the ci-passed label Jul 17, 2024
@haorenfsa
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 186bdec into zilliztech:master Jul 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants