Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ingressClass #109

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

cin-logan
Copy link
Contributor

What this PR does / why we need it:

Since to EKS version 1.22, deprecated nginx kubernetes.io/ingress.class and we need to upgrade to using ingressClassName then i have create PR to do this

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])
  • PR only contains changes for one chart

@sre-ci-robot
Copy link
Collaborator

Welcome @cin-logan! It looks like this is your first PR to zilliztech/milvus-helm 🎉

@haorenfsa
Copy link
Collaborator

Hi @cin-logan, it would be better to add an default empty string value in charts/milvus/values.yaml, so that in other people can easily search for this field if they need it. It can also make the to auto generated documents better, like in https://artifacthub.io/packages/helm/milvus/milvus?modal=values.

@haorenfsa
Copy link
Collaborator

/approve

@cin-logan
Copy link
Contributor Author

could you help me to review it again ? thanks @haorenfsa

@haorenfsa
Copy link
Collaborator

@cin-logan looks good, please bump the chart version to 4.2.1. And we're ready to merge it.

@cin-logan
Copy link
Contributor Author

Sorry for the inconvenience, I have force-pushed again 😢. Could you check it, @haorenfsa

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cin-logan, haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jul 18, 2024
@haorenfsa
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 3726694 into zilliztech:master Jul 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants