Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add elastic search wrapper #509

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

AvikantSrivastava
Copy link
Contributor

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AvikantSrivastava
To complete the pull request process, please assign cxie after the PR has been reviewed.
You can assign the PR to them by writing /assign @cxie in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +82 to +84
def rebuild(self, ids=None) -> bool:
pass

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimFG @cxie @xiaofan-luan
do we need a rebuild method for Elastic Search?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the index can be updated as the data changes, rebuild does not need to be implemented. If not, say faiss, you need to implement

top_k: int = 1,
namespace: str = "",
):
self._client = Elasticsearch("http://localhost:9200")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimFG @cxie @xiaofan-luan
I am currently running a local docker image of elastic search. What should be the hostname for the production use cases here?

Also, a point to note, I have used a http URL since, TLS was required to use a https with Elastic Search

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps through a variable, let the user pass the url parameter by himself. The default value of the parameter is: "http://localhost:9200"

@AvikantSrivastava AvikantSrivastava marked this pull request as ready for review August 6, 2023 23:12
@SimFG SimFG self-assigned this Aug 7, 2023
@SimFG
Copy link
Collaborator

SimFG commented Aug 7, 2023

@AvikantSrivastava please make the dev branch as the target branch

@AvikantSrivastava AvikantSrivastava changed the base branch from main to dev August 7, 2023 11:43
@AvikantSrivastava
Copy link
Contributor Author

@AvikantSrivastava please make the dev branch as the target branch

done

@SimFG
Copy link
Collaborator

SimFG commented Aug 8, 2023

@AvikantSrivastava hi, you need to check the failed process, like pylint and unit test, and add some unit test cases for the elastic search vector store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants