Add zigpy_zboss to the RADIO_TO_PACKAGE map #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add logging configuration as well? You can see examples for the other radio libraries. |
|
Surprisingly, it's already there. Not sure how it worked without this entry in the RADIO_TO_PACKAGE map though. |
|
Interesting! I think this was missed in the previous PR adding the library. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #44 +/- ##
=====================================
Coverage 2.23% 2.23%
=====================================
Files 8 8
Lines 492 492
=====================================
Hits 11 11
Misses 481 481 ☔ View full report in Codecov by Sentry. |
|
That will happen. I removed a space that the formatter didn't like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't use the Zboss radios without this entry. With it, I've had success using the various commands with an nrf52840 dongle through zboss.