-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable configuration url #505
Conversation
Great, this will probably land in the HA 2023.8 release, so let's merge this in September so it will be included in the Z2M October release. Note when merged: test this on edge addon. |
c751cbe
to
aed9541
Compare
I repushed without one of the |
aed9541
to
b5c9c40
Compare
I managed to test by patching HA and the entrypoint, and this won't work currently (the lovelace UI redirects to the default dashboard instead). At least it does not break anymore 😅 |
For the record, home-assistant/core#96107 has been merged. Now what is needed is for the frontend to manage such links, i.e. it should setup the ingress cookie AND display it within an iframe (see home-assistant/frontend#11273 (comment)) |
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Not stale |
@fthiery ready for merge? |
We could merge it right now (HA will not crash anymore), it would display the button, but there are 2 problems with it (both sitting in the UI code):
I think it would create too much confusion as is, so i'd say we wait until i find the time to figure it out. |
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Second try for reverted #499, please do not merge until home-assistant/core#96107 is shipped