Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configuration url #505

Closed
wants to merge 1 commit into from

Conversation

fthiery
Copy link
Contributor

@fthiery fthiery commented Jul 7, 2023

Second try for reverted #499, please do not merge until home-assistant/core#96107 is shipped

@Koenkk
Copy link
Contributor

Koenkk commented Jul 7, 2023

Great, this will probably land in the HA 2023.8 release, so let's merge this in September so it will be included in the Z2M October release.

Note when merged: test this on edge addon.

@fthiery
Copy link
Contributor Author

fthiery commented Jul 10, 2023

I repushed without one of the / chars, or the URL would have been
homeassistant:///api/hassio_ingress/1234568

@fthiery
Copy link
Contributor Author

fthiery commented Jul 10, 2023

I managed to test by patching HA and the entrypoint, and this won't work currently (the lovelace UI redirects to the default dashboard instead). At least it does not break anymore 😅

@fthiery
Copy link
Contributor Author

fthiery commented Jul 24, 2023

For the record, home-assistant/core#96107 has been merged. Now what is needed is for the frontend to manage such links, i.e. it should setup the ingress cookie AND display it within an iframe (see home-assistant/frontend#11273 (comment))

@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 24, 2023
@fthiery
Copy link
Contributor Author

fthiery commented Aug 30, 2023

Not stale

@github-actions github-actions bot removed the Stale label Aug 31, 2023
@Koenkk
Copy link
Contributor

Koenkk commented Sep 6, 2023

@fthiery ready for merge?

@fthiery
Copy link
Contributor Author

fthiery commented Sep 7, 2023

We could merge it right now (HA will not crash anymore), it would display the button, but there are 2 problems with it (both sitting in the UI code):

  • the ingress cookie it not automatically set (yet)
  • even when it is (e.g. after entering the Z2M frontend once), the UI does not work unless you middle click

I think it would create too much confusion as is, so i'd say we wait until i find the time to figure it out.

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 8, 2023
@Koenkk Koenkk removed the Stale label Oct 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Nov 8, 2023
@github-actions github-actions bot closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants