Add ES5 validation #741
Merged
Add ES5 validation #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed with the prettier update; it defaults to placing trailing commas in function calls which is a ES6 feature.
Short-hand key/value is a ES6 feature
This makes sure that the main library code is ES5 compatible and ES6 features aren't used accidentally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the main library code is ES5 compatible and ES6 features aren't used accidentally.
As part of this, Prettier settings were changed to format code with ES5 compliant trailing commas; this was a regression that didn't make it into any versioned builds.