Integrate Prettier for all JS source #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation to prettier integration
|
|
This makes the code style consistent across various uses of JS and also improves integration with editors that use LSP format-on-save like Zed.
Instead of using a variable prefix we now use a comment suffix to indicate embedding which allows the string literal to be split onto its own line. Also adjust regexes for UMD which fixes .module.js building.
|
Not sure I like some aspects here; my biggest issue is printWidth behavior. It's similar to clang-format for fixed-width column limit except that when a line exceeds that, prettier breaks out every expression on a single line. This PR currently works around that by using an excessively large printWidth but that also results in new long lines being created in opposition to existing line breaks... |
|
Going to cherry-pick some consistency changes like tabs and builds separately but for now we probably don't really need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code style consistent across various uses of JS and also
improves integration with editors that use LSP format-on-save like Zed.
As part of this, Wasm patching has been changed to recognize trailing embed
comments as that is friendly to Prettier's line splitting.