Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dst detection after code review comments #2217

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

Jrende
Copy link
Collaborator

@Jrende Jrende commented Sep 29, 2024

Description

This PR cleans up the code for showing a label when daylight savings time goes into / out of effect

Changes

  • Changes the getDSTChange function to instead return 'summertime', 'wintertime' or undefined depending on which change occurs that day

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@richardolsson richardolsson merged commit 0952257 into main Sep 29, 2024
6 checks passed
@richardolsson richardolsson deleted the dst-display-code-cleanup branch September 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants