Issue 2096/error handling for notes upload #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jrende
force-pushed
the
issue-2096/error-handling-for-notes-upload
branch
from
265d9bc
to
a35e978
Compare
Jrende
force-pushed
the
issue-2096/error-handling-for-notes-upload
branch
from
a35e978
to
9f00846
Compare
richardolsson
requested changes
Sep 29, 2024
There was a problem hiding this comment.
Awesome work! I've tried to preview build to confirm that it works, and I've reviewed the code which looks mostly very good. I don't love how many components are involved though, so I'm wondering if it would make sense to keep the state within ZUITimeline. But I can totally be convinced otherwise!
I would like to change the text of the error message though. 👇
src/pages/organize/[orgId]/journeys/[journeyId]/[instanceId]/index.tsx
Outdated
Show resolved
Hide resolved
richardolsson
approved these changes
Sep 30, 2024
richardolsson
deleted the
issue-2096/error-handling-for-notes-upload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it so you get an error message when trying to upload a too long journey note, instead of just annihilating your hard-written text.
Screenshots
Changes
Related issues
Resolves #2096