Show the loading state when duplicates are loading. #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardolsson
requested changes
Sep 26, 2024
|
|
||
| return ( | ||
| <> | ||
| {filteredList.length === 0 && ( | ||
| {duplicates.isLoading && ( | ||
| <CircularProgress color="inherit" size="1.5rem" /> |
There was a problem hiding this comment.
I feel like this is missing a margin/padding around it. This is what it looks like when I throttle my connection to "3G" in order to slow down loading:
The next case (empty state) has a 2 unit margin. The last case (list) has a 1.5 unit padding. I'm thinking all three should probably be the same instead?
Also, maybe the circular loading indicator should be centered? Wrapping it in a box looking something like this should work:
<Box display="flex" justifyContent="center" m={2}>
<CircularProgress />
</Box>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shows the loading indicator when duplicates are being loaded.
Screenshots
I am nowhere near fast enough to pull this. Just trust me.
Changes
Adds the loading indicator when the duplicates are in a loading state.
Related issues
Resolves #2057