Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Makefile): fix coverage-report target #898

Merged
merged 4 commits into from
Aug 3, 2023
Merged

chore(Makefile): fix coverage-report target #898

merged 4 commits into from
Aug 3, 2023

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented Aug 2, 2023

Description

  • Fix coverage-report to generate a coverage.html file
  • Add coverage html to gitignore

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis self-assigned this Aug 2, 2023
@lumtis lumtis requested a review from ws4charlie as a code owner August 3, 2023 08:07
@lumtis lumtis merged commit b984dea into develop Aug 3, 2023
17 checks passed
@lumtis lumtis deleted the chore/coverage-html branch October 27, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadeev fadeev fadeev approved these changes

@kingpinXD kingpinXD kingpinXD approved these changes

@brewmaster012 brewmaster012 Awaiting requested review from brewmaster012 brewmaster012 is a code owner

@kevinssgh kevinssgh Awaiting requested review from kevinssgh

@ws4charlie ws4charlie Awaiting requested review from ws4charlie ws4charlie is a code owner

Assignees

@lumtis lumtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumtis @fadeev @kingpinXD