refactor: add error checks for missing chain id #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingpinXD
requested review from
brewmaster012,
kevinssgh and
fadeev
as code owners
…inid-checks # Conflicts: # zetaclient/evm_client.go
brewmaster012
requested changes
Jul 6, 2023
brewmaster012
requested changes
Jul 6, 2023
| if destChain == nil { | ||
| ob.logger.ExternalChainWatcher.Warn().Msgf("chain id not supported %d", event.DestinationChainId.Int64()) | ||
| continue | ||
| } | ||
| destAddr := clienttypes.BytesToEthHex(event.DestinationAddress) | ||
|
|
||
| if strings.EqualFold(destAddr, ob.cfg.EVMChainConfigs[destChain.ChainId].CoreParams.ZETATokenContractAddress) { |
There was a problem hiding this comment.
Let's be defensive and check whether ob.cfg.EVMChainConfigs[destChain.ChainId] is nil or not.
brewmaster012
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dereferencing chain id from core parameters, there is the possibility of a segmentation fault. If the chain ID component of inbound transaction is unknown to zetacore + zetaclient, a nil pointer is dereferenced in an attempt to retrieve info.
Closes:
Type of change