Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zetaclient)!: add support for TON withdrawals #3020

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

swift1337
Copy link
Contributor

@swift1337 swift1337 commented Oct 17, 2024

Changes

  • TON signer
  • watchOutbound
  • watchGasPrice
  • TBD...

Prerequisites

Closes #2807
Closes #2809

@swift1337 swift1337 self-assigned this Oct 17, 2024
Copy link

!!!WARNING!!!
nosec detected in the following files: pkg/contracts/ton/coin.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Oct 17, 2024
@swift1337 swift1337 added the TON_TESTS Runs TON E2E tests label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 42.25352% with 41 lines in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (ae6ab23) to head (109b8f4).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/contracts/ton/gateway.go 17.24% 23 Missing and 1 partial ⚠️
pkg/contracts/ton/gateway_deploy.go 60.97% 10 Missing and 6 partials ⚠️
pkg/contracts/ton/coin.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3020      +/-   ##
===========================================
- Coverage    65.77%   64.81%   -0.96%     
===========================================
  Files          398      410      +12     
  Lines        22421    28479    +6058     
===========================================
+ Hits         14747    18459    +3712     
- Misses        6900     9218    +2318     
- Partials       774      802      +28     
Files with missing lines Coverage Δ
pkg/contracts/ton/coin.go 0.00% <0.00%> (ø)
pkg/contracts/ton/gateway_deploy.go 60.97% <60.97%> (ø)
pkg/contracts/ton/gateway.go 45.71% <17.24%> (-15.27%) ⬇️

... and 391 files with indirect coverage changes

@swift1337 swift1337 changed the title Feat/ton withdrawals feat(zetaclient)!: add support for TON withdrawals Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nosec TON_TESTS Runs TON E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TON Signer E2E test-cases TON TSS Signer
1 participant