Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajout de la documentation #4
base: master
Are you sure you want to change the base?
Ajout de la documentation #4
Changes from 1 commit
91cb241
4364493
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On avait parlé du fait d'adapter le code afin qu'il soit aussi possible d'écrire
tant que
morceau
a un attributposition
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peu clair potentiellement quand on ne connaît pas du tout Python (d'où vient ce
.position
?).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le mot
instance
n'a jamais été vu avant. Quid ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ correction orthographique : "crée" -> "créée"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est vraiment gênant ? Le mot instance me semble assez transparent ici : "une nouvelle instance du serpent" = "un nouveau serpent".
@Situphen : corrigé.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le plus tard est à peine plus bas. Peut-être vaudrait-il mieux reformuler cette partie, ou retirer cette phrase au profit du paragraphe « Position du serpent » (ou y laisser un pointeur : « on verra un peu plus bas comment s'en servir »…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Par rapport au code : pourquoi demander la taille en paramètre quand elle est stockée dans l'objet de toute façon ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour pouvoir itérer sur une partie des morceaux seulement ; aucune idée de pourquoi je voulais faire ça, mais clairement c'était à dessein. TODO: voir si c'est utilisé.