Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a command line option no-configure-network #213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

laduke
Copy link
Contributor

@laduke laduke commented Mar 23, 2023

For #205
Makes it not configure the dns servers and domain
on the zerotier network in my.zerotier.com

That was easy.
Will try to add a test if I get motivated.

For #205
Makes it not configure the dns servers and domain
on the zerotier network in my.zerotier.com
@aplum
Copy link

aplum commented Mar 24, 2023

Thanks for working on this @laduke! I'll try to test this in my environment soon.

Could you also add some documentation about this option? Maybe something like this under "Configuration" in the main README:

- no_configure_network: (bool) Prevent zeronsd from changing the DNS Search Domain and Server Addresses in ZeroTier Central. Default is `false`. Typically only necessary in more complex setups with multiple DNS servers. Also, with this enabled, zeronsd can run with a token that has read-only access.

@laduke
Copy link
Contributor Author

laduke commented Mar 24, 2023

Sure. There should be some docs for it under zeronsd help start now.

@aplum
Copy link

aplum commented Mar 24, 2023

I've tested this in our environment and it works. Tested both true and false. (Built using docker, then copied the binary to our production machine and replaced /usr/bin/zeronsd. There's probably a better way, but that worked.)

One little issue: I'm using a YAML config file and for some reason this option seems to be required in it? If I omit it, zeronsd exits with the message missing field `no_configure_network`. Btw, this is also true for wildcard and local_url.

There should be some docs for it under zeronsd help start now.

Any chance you could also add it to the README? This wouldn't be the first project that has the functionality I need, but it takes me a while to find because it's one of the few options not in the README 🙂

@laduke
Copy link
Contributor Author

laduke commented Mar 24, 2023

If I omit it, zeronsd exits with the message missing field no_configure_network. Btw, this is also true for wildcard and local_url.

That's... fun. Need to think about that.

@laduke
Copy link
Contributor Author

laduke commented Mar 24, 2023

I'd fixup the other issues in different PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants