Create some tests

[laduke]

This only lints for "errors" -S error

The shebang line is injected from build-install.sh. There was probably a reason for that, so I marked it ignored.

There are a few more errors like:

In install.sh.in line 233:
        if   [[ "$DISTRIBUTION" == "ubuntu" && "$VERSION" < "22.04" ]]; then
                                                            ^-----^ SC2072 (error): Decimals are not supported. Either use integers only, or use bc or awk to compare.

if we enable warnings and info, there are ~20 things to fix. But it's style stuff like

In install.sh.in line 364:
        cat /dev/null | $SUDO zypper addrepo -t YUM -G ${ZT_BASE_URL_HTTP}redhat/el/9 zerotier
            ^-------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

I'll cat if I want to.

[glimberg]

nice

[laduke]

i am slightly afraid to touch the errors

[laduke]

I tried to make an action to run curl | bash on most of the distros the script supports. All the redhat type ones don't have systemd in their image, so it doesn't work. Couldn't get mint to work either. We'd need to make VMs someday.

[Squelch]

There are a few more errors like:

In install.sh.in line 233:
        if   [[ "$DISTRIBUTION" == "ubuntu" && "$VERSION" < "22.04" ]]; then
                                                            ^-----^ SC2072 (error): Decimals are not supported. Either use integers only, or use bc or awk to compare.

if we enable warnings and info, there are ~20 things to fix.

Does -lt and -gt instead of < and > produce the same error regarding version numbers? IIRC </> are for string comparisons in bash, -lt/-gt for numerals.

[edit] I'm mobile right now, so unable to verify

[glimberg]