net: lwm2m: use path as block context retrieval #57228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainPelletant
force-pushed
the
net/lwm2m/change-block-context-retrieval
branch
from
c7246c4
to
c82922d
Compare
rlubos
reviewed
Apr 25, 2023
Comment on lines
164
to
165
| if (memcmp(path, &lwm2m_block1_context()[i].path, | ||
| sizeof(struct lwm2m_obj_path)) == 0) { |
There was a problem hiding this comment.
This still looks wrongly aligned (please align to the opening bracket):
Suggested change
| if (memcmp(path, &lwm2m_block1_context()[i].path, | |
| sizeof(struct lwm2m_obj_path)) == 0) { | |
| if (memcmp(path, &lwm2m_block1_context()[i].path, | |
| sizeof(struct lwm2m_obj_path)) == 0) { |
rlubos
reviewed
Apr 25, 2023
| *ctx = NULL; | ||
|
|
||
| for (i = 0; i < NUM_BLOCK1_CONTEXT; i++) { | ||
| if (block1_contexts[i].tkl == tkl && | ||
| memcmp(token, block1_contexts[i].token, tkl) == 0) { | ||
| if (memcmp(path, &lwm2m_block1_context()[i].path, |
There was a problem hiding this comment.
Suggested change
| if (memcmp(path, &lwm2m_block1_context()[i].path, | |
| if (memcmp(path, &lwm2m_block1_context[i].path, |
RomainPelletant
force-pushed
the
net/lwm2m/change-block-context-retrieval
branch
5 times, most recently
from
c176f37
to
c8708be
Compare
RomainPelletant
changed the title
|
DNM added : Test scheduled tomorrow with Leshan for FW update in push mode. |
RomainPelletant
force-pushed
the
net/lwm2m/change-block-context-retrieval
branch
from
c8708be
to
c2e8786
Compare
RomainPelletant
changed the title
|
Successfully pushed firmware from Leshan |
Replace block context retrieval using object path instead of token. Update block context structure Fix issue zephyrproject-rtos#57165 Signed-off-by: romain pelletant <[email protected]>
RomainPelletant
force-pushed
the
net/lwm2m/change-block-context-retrieval
branch
from
c2e8786
to
3ed5fcf
Compare
|
Missing update in TLV writer found by CI |
rlubos
approved these changes
Apr 26, 2023
SeppoTakalo
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace block context retrieval using object path instead of token. Changing token between each block is a correct behavior and restore a functional link with Leshan/Californium
Fix issue #57165