Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Experimental Cache compilation #141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/curly.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,5 @@ def self.valid?(template, presenter_class)
require 'curly/compiler'
require 'curly/presenter'
require 'curly/template_handler'
require 'curly/configuration'
require 'curly/railtie' if defined?(Rails)
27 changes: 27 additions & 0 deletions lib/curly/configuration.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
module Curly
extend self

def configuration
@configuration ||= Configuration.new
end

def configure
yield(configuration)
end

def configuration=(c)
@configuration = c
end

def reset
@configuration = Configuration.new
end

class Configuration
attr_accessor :cache_store

def initialize
@cache_store = nil
end
end
end
14 changes: 13 additions & 1 deletion lib/curly/template_handler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,19 @@ class << self
# Returns a String containing the Ruby code representing the template.
def call(template)
instrument(template) do
compile(template)
if Curly.configuration.cache_store
cache_key = [
"CurlyCompilation",
template.virtual_path,
template.cache_key,
].join("/")

Curly.configuration.cache_store.fetch(cache_key) do
compile(template)
end
else
compile(template)
end
end
end

Expand Down
41 changes: 41 additions & 0 deletions spec/configuration_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
describe Curly::Configuration do
after do
Curly.reset
end

describe "#cache_store" do
it "defaults to nil" do
cache_store = Curly::Configuration.new.cache_store

expect(cache_store).to be_nil
end
end

describe ".configure" do
before do
Curly.configure do |config|
config.cache_store = 'foobar'
end
end

it "returns correct value for cache_store" do
presenters_namespace = Curly.configuration.cache_store

expect(presenters_namespace).to eq('foobar')
end
end

describe ".reset" do
it "resets the configuration to default value" do
Curly.configure do |config|
config.cache_store = 'foobarbaz'
end

Curly.reset

cache_store = Curly::Configuration.new.cache_store

expect(cache_store).to be_nil
end
end
end