Skip to content

Apply suggestions from code review

Codecov / codecov/patch failed Jul 6, 2023 in 1s

59.48% of diff hit (target 70.20%)

View this Pull Request on Codecov

59.48% of diff hit (target 70.20%)

Annotations

Check warning on line 186 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L183-L186 

Added lines #L183 - L186 were not covered by tests

Check warning on line 188 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L188 

Added line #L188 was not covered by tests

Check warning on line 195 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L191-L195 

Added lines #L191 - L195 were not covered by tests

Check warning on line 208 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L206-L208 

Added lines #L206 - L208 were not covered by tests

Check warning on line 221 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L219-L221 

Added lines #L219 - L221 were not covered by tests

Check warning on line 223 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L223 

Added line #L223 was not covered by tests

Check warning on line 234 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L234 

Added line #L234 was not covered by tests

Check warning on line 238 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L236-L238 

Added lines #L236 - L238 were not covered by tests

Check warning on line 555 in zcash_client_backend/src/data_api/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/wallet.rs#L555 

Added line #L555 was not covered by tests

Check warning on line 620 in zcash_client_backend/src/data_api/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/wallet.rs#L620 

Added line #L620 was not covered by tests

Check warning on line 153 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L152-L153 

Added lines #L152 - L153 were not covered by tests

Check warning on line 156 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L155-L156 

Added lines #L155 - L156 were not covered by tests

Check warning on line 159 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L158-L159 

Added lines #L158 - L159 were not covered by tests

Check warning on line 250 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L248-L250 

Added lines #L248 - L250 were not covered by tests

Check warning on line 273 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L269-L273 

Added lines #L269 - L273 were not covered by tests

Check warning on line 296 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L295-L296 

Added lines #L295 - L296 were not covered by tests

Check warning on line 327 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L326-L327 

Added lines #L326 - L327 were not covered by tests

Check warning on line 333 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L332-L333 

Added lines #L332 - L333 were not covered by tests

Check warning on line 465 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L463-L465 

Added lines #L463 - L465 were not covered by tests

Check warning on line 234 in zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs#L234 

Added line #L234 was not covered by tests
View more details on Codecov