-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protobuf representation for transaction proposals #891
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 70.14% 69.79% -0.35%
==========================================
Files 141 142 +1
Lines 13674 13959 +285
==========================================
+ Hits 9591 9743 +152
- Misses 4083 4216 +133 ☔ View full report in Codecov by Sentry. |
65f4204
to
4c501da
Compare
Folks, do you have an expected deadline for accepting comments on this? |
I would really like to get this in to an SDK release immediately following
Spend-before-Sync, but the proposal to allow using ZIP-317 fees without
displaying the fees to the user up front takes the pressure off a little
bit. But ideally wallet devs would be able to adopt SbS and the proposal
system simultaneously.
…On Fri, Aug 18, 2023 at 9:54 AM Pacu ***@***.***> wrote:
Folks, do you have an expected deadline for accepting comments on this?
Just prioritizing here 😅
—
Reply to this email directly, view it on GitHub
<#891 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGXR5Z5D5J5UY3GVZEHDLXV6F4HANCNFSM6AAAAAA3I32QNU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left non-blocking comments on PR.
- possible feature request: create proposals from ZIP-321 string-serialized requests
- Evaluate ways to make it hard (or better impossible) for
Proposal
's payment request property to be out of sync of aProposal
instance. - Consider adding "privacy policy" to the transaction proposal similar as the ones documented in
z_sendmany
andz_shieldcoinbase
on Zcashd.
a2d416a
to
ad08dec
Compare
4899fe5
to
7aab6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 7aab6fd with a few nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with typo fix suggestions and a non-blocking comment.
1c0ca0e
to
e0ac6bf
Compare
Co-authored-by: Daira Emma Hopwood <[email protected]> Co-authored-by: str4d <[email protected]>
e0ac6bf
to
c5f48f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-utACK c5f48f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK
A comment change to the source file was made in #891 before merging, but the generated file was not updated to match.
In order to make complete information about proposed transactions readily available to wallets, it's necessary to provide a mechanism to pass a
TransactionProposal
across the FFI. This PR adds a Protobuf representation for proposed transactions and implements conversions back and forth between the protobuf representation and the native type.Closes #1093.