Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zcash_client_backend: Make scan range bounds required in data_api::chain::scan_cached_blocks #867

Merged
merged 3 commits into from
Jul 6, 2023

Make `from_height` and `limit` parameters to `scan_cached_blocks` non…

98147e0
Select commit
Loading
Failed to load commit list.
Merged

zcash_client_backend: Make scan range bounds required in data_api::chain::scan_cached_blocks #867

Make `from_height` and `limit` parameters to `scan_cached_blocks` non…
98147e0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jul 6, 2023 in 0s

60.71% of diff hit (target 70.20%)

View this Pull Request on Codecov

60.71% of diff hit (target 70.20%)

Annotations

Check warning on line 186 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L183-L186

Added lines #L183 - L186 were not covered by tests

Check warning on line 188 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L188

Added line #L188 was not covered by tests

Check warning on line 195 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L191-L195

Added lines #L191 - L195 were not covered by tests

Check warning on line 211 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L209-L211

Added lines #L209 - L211 were not covered by tests

Check warning on line 213 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L213

Added line #L213 was not covered by tests

Check warning on line 224 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L224

Added line #L224 was not covered by tests

Check warning on line 228 in zcash_client_backend/src/data_api/chain.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/chain.rs#L226-L228

Added lines #L226 - L228 were not covered by tests

Check warning on line 555 in zcash_client_backend/src/data_api/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/wallet.rs#L555

Added line #L555 was not covered by tests

Check warning on line 620 in zcash_client_backend/src/data_api/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api/wallet.rs#L620

Added line #L620 was not covered by tests

Check warning on line 153 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L152-L153

Added lines #L152 - L153 were not covered by tests

Check warning on line 156 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L155-L156

Added lines #L155 - L156 were not covered by tests

Check warning on line 159 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L158-L159

Added lines #L158 - L159 were not covered by tests

Check warning on line 250 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L248-L250

Added lines #L248 - L250 were not covered by tests

Check warning on line 273 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L269-L273

Added lines #L269 - L273 were not covered by tests

Check warning on line 296 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L295-L296

Added lines #L295 - L296 were not covered by tests

Check warning on line 327 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L326-L327

Added lines #L326 - L327 were not covered by tests

Check warning on line 333 in zcash_client_backend/src/scanning.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/scanning.rs#L332-L333

Added lines #L332 - L333 were not covered by tests

Check warning on line 465 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L463-L465

Added lines #L463 - L465 were not covered by tests

Check warning on line 234 in zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/init/migrations/ufvk_support.rs#L234

Added line #L234 was not covered by tests