Add correct BlockHeight subtraction & remove panics.
#1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to the implementation of `Sub<BlockHeight> for BlockHeight` that was removed in version `0.3.0`, a saturating subtraction for block heights having a return type of `u32` makes sense for `BlockHeight`. Subtracting one block height from another yields the delta between them. Other block height addition and subtraction operations have been made saturating, removing panics and the possibility of overflow.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
=======================================
Coverage 61.17% 61.17%
=======================================
Files 141 141
Lines 16645 16645
=======================================
Hits 10183 10183
Misses 6462 6462 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In contrast to the implementation of
Sub<BlockHeight> for BlockHeightthat was removed in version0.3.0, a saturating subtraction for block heights having a return type ofu32makes sense forBlockHeight. Subtracting one block height from another yields the delta between them.Other block height addition and subtraction operations have been made saturating, removing panics and the possibility of overflow.