Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support older sqlite versions. #1511

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Support older sqlite versions. #1511

merged 6 commits into from
Sep 3, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 61.07%. Comparing base (50cdf73) to head (f063e7a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_sqlite/src/wallet/init.rs 66.66% 8 Missing ⚠️
...rc/wallet/init/migrations/support_legacy_sqlite.rs 60.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   61.06%   61.07%           
=======================================
  Files         141      142    +1     
  Lines       16675    16710   +35     
=======================================
+ Hits        10182    10205   +23     
- Misses       6493     6505   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daira daira force-pushed the sqlite_legacy_support branch 2 times, most recently from a8c4d6d to 260c302 Compare August 23, 2024 18:39
@nuttycom
Copy link
Contributor Author

It turns out that Google is requiring Android API 34 anyway, so this PR is not needed: https://support.google.com/googleplay/android-developer/answer/11926878?hl=en

@nuttycom nuttycom closed this Aug 23, 2024
@nuttycom nuttycom deleted the sqlite_legacy_support branch August 23, 2024 22:11
@nuttycom nuttycom restored the sqlite_legacy_support branch August 27, 2024 14:00
@nuttycom nuttycom reopened this Aug 27, 2024
@nuttycom
Support older sqlite versions.
c91b34e 
The `FALSE` constant was introduced in sqlite version 3.23.0,
but Android does not support this version of sqlite until API
level 30; we support back to Android API 27 so we have to use
`0` as the constant for `FALSE` instead.
@nuttycom
Copy link
Contributor Author

force-pushed to remove changes that are unnecessary as we now verify that we're using SQLite 3.35.0 or higher.

@nuttycom
Copy link
Contributor Author

force-pushed to fix cargo fmt error.

@HonzaR HonzaR mentioned this pull request Sep 2, 2024
Merged
13 tasks
daira
daira previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but I argue that we no longer need the version check. I don't object to keeping it; if we do, fix the clippy lints and please add a comment saying that what is being checked is the version used by rusqlite, which may be different than the version used to run view queries.

@nuttycom
Copy link
Contributor Author

nuttycom commented Sep 3, 2024 •
edited
Loading

@daira Comments addressed.

@nuttycom nuttycom force-pushed the sqlite_legacy_support branch 3 times, most recently from af9d5b3 to 1cfcfa2 Compare September 3, 2024 18:19
daira
daira previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5e6a8f0

daira
daira approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f063e7a

@nuttycom nuttycom merged commit db06580 into main Sep 3, 2024
28 checks passed
@nuttycom nuttycom deleted the sqlite_legacy_support branch September 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuttycom @daira