Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release zcash_client_sqlite 0.8.1 #1021

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

ebfull
Copy link
Collaborator

@ebfull ebfull commented Oct 18, 2023

This is a special hotfix release to fix a high impact bug fixed by #1020. This branch is based off of the zcash_client_sqlite-0.8.0 tag. We'll tag this after review and merge. (We'll have to manually merge though because of changelog conflicts...)

The alternative would be to release what's on main now, which also contains the bugfix, but that will be very intense process as main is not currently in a releasable state.

daira
daira previously approved these changes Oct 18, 2023
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

daira
daira previously approved these changes Oct 19, 2023
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@daira daira dismissed their stale review October 19, 2023 17:12

The merge-base changed after approval.

@daira daira force-pushed the release-zcash_client_sqlite-0.8.1 branch from b1b1be6 to d972668 Compare October 19, 2023 17:15
Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira daira force-pushed the release-zcash_client_sqlite-0.8.1 branch from d972668 to 289f1fd Compare October 19, 2023 17:26
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 289f1fd

@daira
Copy link
Contributor

daira commented Oct 19, 2023

Note that GitHub is not showing the contents of this PR correctly, because there are many changes on main that are not on this branch.

To see what I changed to get CI (hopefully) passing, look at https://github.com/zcash/librustzcash/compare/b88adb4e82504ce82e8f955f8cf07514699653a1..289f1fdf302e3e842a62903213c495c87a441913 .

To see the comparison with zcash_client_sqlite 0.8.0, look at https://github.com/zcash/librustzcash/compare/zcash_client_sqlite-0.8.0..289f1fdf302e3e842a62903213c495c87a441913 .

@ebfull
Copy link
Collaborator Author

ebfull commented Oct 19, 2023

ACK

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
zcash_client_sqlite/src/wallet/init.rs 47.22% <ø> (ø)
zcash_client_sqlite/src/wallet/init/migrations.rs 100.00% <100.00%> (ø)
.../init/migrations/v_transactions_note_uniqueness.rs 60.00% <60.00%> (ø)

📢 Thoughts on this report? Let us know!.

@ebfull ebfull merged commit 84eb082 into main Oct 19, 2023
42 of 45 checks passed
@nuttycom nuttycom deleted the release-zcash_client_sqlite-0.8.1 branch October 24, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants