zcash_client_backend: Move min_confirmations into Proposal
#1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
added
the
C-tech-debt
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
nuttycom
force-pushed
the
wallet/proposals_with_minconf
branch
4 times, most recently
from
4dbd6e7
to
0fb65a5
Compare
nuttycom
force-pushed
the
wallet/proposals_with_minconf
branch
from
0fb65a5
to
c084174
Compare
str4d
reviewed
Oct 31, 2023
| @@ -81,12 +81,39 @@ pub struct Proposal<FeeRuleT, NoteRef> { | |||
| sapling_inputs: Vec<ReceivedSaplingNote<NoteRef>>, | |||
| balance: TransactionBalance, | |||
| fee_rule: FeeRuleT, | |||
| min_confirmations: NonZeroU32, | |||
There was a problem hiding this comment.
Non-blocking: this propagates the mistake I made in suggesting to use a NonZeroU32 for min_confirmations, when we actually need the ability to set this to zero for shielding transactions. Non-blocking because it just moves around the problem, and #873 is about fixing it.
nuttycom
force-pushed
the
wallet/proposals_with_minconf
branch
from
c084174
to
e1892b7
Compare
daira
reviewed
Oct 31, 2023
This fixes an API issue whereby it was possible to execute a `Proposal` with a different value of `min_confirmations` than that with which the `Proposal` was constructed.
nuttycom
force-pushed
the
wallet/proposals_with_minconf
branch
from
e1892b7
to
4cd26b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #1018
This fixes an API issue whereby it was possible to execute a
Proposalwith a different value of
min_confirmationsthan that with which theProposalwas constructed.