Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pydantic v2 #20

Merged
merged 20 commits into from
Sep 25, 2024
Merged

Upgrade to pydantic v2 #20

merged 20 commits into from
Sep 25, 2024

Conversation

gmmajal
Copy link
Contributor

@gmmajal gmmajal commented Sep 20, 2024

Related to: #18

The migration to pydantic v2 is based on https://docs.pydantic.dev/latest/migration/

The following changes have been introduced in qualle:

@gmmajal gmmajal self-assigned this Sep 20, 2024
@gmmajal gmmajal linked an issue Sep 20, 2024 that may be closed by this pull request
@gmmajal gmmajal marked this pull request as draft September 20, 2024 16:12
@gmmajal
Copy link
Contributor Author

gmmajal commented Sep 23, 2024

Some refactoring had to be made to comply with our linters in particular black. A change has been made in github actions with regards to flake8. It will ignore lengthy lines (E501).

@gmmajal gmmajal marked this pull request as ready for review September 23, 2024 15:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (3c2be3b) to head (ec7b91e).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   94.40%   94.54%   +0.13%     
==========================================
  Files          23       23              
  Lines         894      898       +4     
==========================================
+ Hits          844      849       +5     
+ Misses         50       49       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmmajal
Copy link
Contributor Author

gmmajal commented Sep 23, 2024

The changes from the main branch have been pulled into this feature branch. A new poetry.lock file has been created.

@gmmajal
Copy link
Contributor Author

gmmajal commented Sep 24, 2024

Removed the ignore command from the flake8 job present inside .github/workflows

@gmmajal
Copy link
Contributor Author

gmmajal commented Sep 25, 2024

Post request is working on the local instance of qualle. A new unit test has been added to verify the status 422 behavior of our rest api as specified in the openapi.json file.

@gmmajal gmmajal merged commit 4b9bf05 into master Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to pydantic v2
3 participants