clarify that the abstract store api is not normative #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also close #266 |
jbms
approved these changes
Aug 22, 2024
TomNicholas
reviewed
Aug 28, 2024
| @@ -1273,6 +1271,8 @@ when opening a Zarr hierarchy to automatically determine the appropriate store. | |||
| Abstract store interface | |||
| ------------------------ | |||
|
|
|||
| (This subsection is not normative.) | |||
There was a problem hiding this comment.
I feel like this could be a lot clearer, e.g:
Suggested change
| (This subsection is not normative.) | |
| (This subsection is not normative. It is intended only as a recommendation for API design, but does not need to be strictly followed like the specification for the on-disk storage does.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #307