Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support zero-sized chunks #2434

Merged

Conversation

brokkoli71
Copy link
Member

Enabling chunks of size zero and thus arrays of size zero

fixes #1977

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@brokkoli71 brokkoli71 marked this pull request as ready for review October 23, 2024 15:26
@dcherian
Copy link
Contributor

dcherian commented Oct 23, 2024

Is the shape (1, 0, 1) supported too?

EDIT: I see array([], shape=(3, 0), dtype=float64) in the issue.

Can you add min_side=0 to

array_shapes = npst.array_shapes(max_dims=4)
so that we get some more testing?

@brokkoli71
Copy link
Member Author

@dcherian Yes, (1, 0, 1) is supported

@dcherian
Copy link
Contributor

property tests fixed in scalableminds#4

have property tests support zero-sized chunks
@brokkoli71
Copy link
Member Author

Thanks @dcherian ! I tried to think my way into the property tests. That helped a lot.

@dcherian dcherian merged commit 87ca150 into zarr-developers:main Oct 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Support zero-sized arrays
2 participants