Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply ruff isort rules in pre-commit #1862

Closed
wants to merge 1 commit into from

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented May 10, 2024

closes #1860

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman requested a review from d-v-b May 10, 2024 22:20
- id: ruff-format
types_or: [ python, pyi, jupyter ]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only config changes in this PR. Everything else was done by the linters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we should be able to pull the --select I bit out and put it in pyproject.toml

[RF102](https://learn.scientific-python.org/development/guides/style#RF102): isort must be selected
Must select the isort I checks. Recommended:
[tool.ruff.lint]
extend-select = [
  "I",  # isort
]

[RF103](https://learn.scientific-python.org/development/guides/style#RF103): pyupgrade must be selected
Must select the pyupgrade UP checks. Recommended:
[tool.ruff.lint]
extend-select = [
  "UP",  # pyupgrade
]

@jhamman
Copy link
Member Author

jhamman commented May 11, 2024

closing in favor of #1864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant