Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use np.inf instead of PINF/NINF #1842

Merged
merged 3 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions docs/release.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,24 @@ Unreleased

Enhancements
~~~~~~~~~~~~
* Performance improvement for reading and writing chunks if any of the dimensions is size 1. :issue:`1730`
By :user:`Deepak Cherian <dcherian>`.

* Performance improvement for reading and writing chunks if any of the dimensions is size 1.
By :user:`Deepak Cherian <dcherian>` :issue:`1730`.

Docs
~~~~


Maintenance
~~~~~~~~~~~
* Minor updates to use `np.inf` instead of `np.PINF` / `np.NINF` in preparation for NumPy 2.0.0 release.
By :user:`Joe Hamman <jhamman>` :issue:`1842`.

Deprecations
~~~~~~~~~~~~

* Deprecate experimental v3 support by issuing a `FutureWarning`.
Also updated docs to warn about using the experimental v3 version.
By :user:`Joe Hamman <jhamman>` :issue:`1802` and :issue: `1807`.

Deprecations
~~~~~~~~~~~~
By :user:`Joe Hamman <jhamman>` :issue:`1802` and :issue:`1807`.
* Deprecate the following stores: :class:`zarr.storage.DBMStore`, :class:`zarr.storage.LMDBStore`,
:class:`zarr.storage.SQLiteStore`, :class:`zarr.storage.MongoDBStore`, :class:`zarr.storage.RedisStore`,
and :class:`zarr.storage.ABSStore`. These stores are slated to be removed from Zarr-Python in version 3.0.
Expand Down
4 changes: 2 additions & 2 deletions zarr/meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,9 @@ def decode_fill_value(cls, v: Any, dtype: np.dtype, object_codec: Any = None) ->
if v == "NaN":
return np.nan
elif v == "Infinity":
return np.PINF
return np.inf
elif v == "-Infinity":
return np.NINF
return -np.inf
else:
return np.array(v, dtype=dtype)[()]
elif dtype.kind in "c":
Expand Down
4 changes: 2 additions & 2 deletions zarr/tests/test_meta.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,8 @@ def test_encode_decode_array_structured():
def test_encode_decode_fill_values_nan():
fills = (
(np.nan, "NaN", np.isnan),
(np.NINF, "-Infinity", np.isneginf),
(np.PINF, "Infinity", np.isposinf),
(-np.inf, "-Infinity", np.isneginf),
(np.inf, "Infinity", np.isposinf),
)

for v, s, f in fills:
Expand Down