-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add numpy 2 release candidate to test matrix #1828
Conversation
Thanks Joe! 🙏 Looks good Was trying to look in the CI logs to see where NumPy gets installed, but was having trouble seeing it. Do you know where this happens? Is that info just getting swallowed somewhere? |
@jakirkham - your comment uncovered something in our new CI setup. We weren't passing the numpy version to the list of dependencies. That is fixed in this PR now. Note: the test failures are in the v2 code path. @maxrjones - could you take a look here and tell us if the |
features = ["optional"] | ||
|
||
[tool.hatch.envs.test.scripts] | ||
run-coverage = "pytest --cov-config=pyproject.toml --cov=pkg --cov=tests" | ||
run = "run-coverage --no-cov" | ||
run-verbose = "run-coverage --verbose" | ||
run-mypy = "mypy src" | ||
list-env = "pip list" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is used in the test github action
dependencies = [ | ||
"numpy~={matrix:numpy}", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was what we were missing. Eeek!
Sounds like a productive exercise then 🙂 Thanks Joe! 🙏 |
The only dependency that is different between |
Looking good. Thanks Joe! 🙏 Can see NumPy 2.0.0rc1 getting installed and CI passing 🎉 |
closes #1818
cc @jakirkham
TODO: