Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force libc++ on macOS #211

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Force libc++ on macOS #211

merged 2 commits into from
Nov 9, 2019

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Nov 9, 2019

Some Python builds still try to use stdlibc++, which really doesn't exist on macOS any more. So force libc++ to bypass this issue.

Note: Hopefully addresses the macOS part of issue ( #210 ).

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

Some Python builds still try to use `stdlibc++`, which really doesn't
exist on macOS any more. So force `libc++` to bypass this issue.
@jakirkham
Copy link
Member Author

@jni, would you be able to try this out and let me know if it helps the macOS build situation? 🙂

@jni
Copy link

jni commented Nov 9, 2019

How do I build from source? If I try pip install -U . on your branch, I get:

    creating build/temp.macosx-10.7-x86_64-3.7
    creating build/temp.macosx-10.7-x86_64-3.7/numcodecs
    gcc -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/Users/nuneziglesiasj/conda/envs/napari-numcodecs/include -arch x86_64 -I/Users/nuneziglesiasj/conda/envs/napari-numcodecs/include -arch x86_64 -DHAVE_LZ4=1 -DHAVE_SNAPPY=1 -DHAVE_ZLIB=1 -DHAVE_ZSTD=1 -Ic-blosc/blosc -I/Users/nuneziglesiasj/conda/envs/napari-numcodecs/include/python3.7m -c numcodecs/blosc.c -o build/temp.macosx-10.7-x86_64-3.7/numcodecs/blosc.o -msse2 -stdlib=libc++ -DSHUFFLE_SSE2_ENABLED
    numcodecs/blosc.c:705:10: fatal error: 'blosc.h' file not found
    #include "blosc.h"
             ^~~~~~~~~

@jakirkham
Copy link
Member Author

There's a git submodule for Blosc. So you would need to run git submodule update --init to grab that.

@jni
Copy link

jni commented Nov 9, 2019

Ok, it's working now! 🎉

@jakirkham
Copy link
Member Author

That's great news! Thanks for testing and bearing with me. 😅

@jni
Copy link

jni commented Nov 9, 2019

Least I can do! 😅

@jakirkham jakirkham merged commit 7c07db4 into zarr-developers:master Nov 9, 2019
@jakirkham jakirkham deleted the force_libcxx_macos branch November 9, 2019 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants