Add Icechunk Support #256
Merged
Add Icechunk Support #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpiannucci
had a problem deploying
to
test-release
GitHub Actions
Failure
mpiannucci
had a problem deploying
to
test-release
GitHub Actions
Failure
for more information, see https://pre-commit.ci
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
Okay thinnkkkkk were finally solid |
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
TomNicholas
reviewed
Oct 22, 2024
Comment on lines
173
to
175
| # Check with xarray | ||
| ds = open_zarr(store=icechunk_filestore, zarr_format=3, consolidated=False) | ||
| assert np.allclose(ds.air.to_numpy(), expected_ds.air.to_numpy()) |
Comment on lines
271
to
285
| root_group = group(store=icechunk_filestore) | ||
| air_array = root_group["air"] | ||
| assert isinstance(air_array, Array) | ||
| assert air_array.shape == (3, 4) | ||
| assert air_array.dtype == np.dtype("float64") | ||
| assert air_array.attrs["units"] == "km" | ||
| assert np.allclose(air_array[:], la_v[:]) | ||
|
|
||
| pres_array = root_group["pres"] | ||
| assert isinstance(pres_array, Array) | ||
| assert pres_array.shape == (3, 4) | ||
| assert pres_array.dtype == np.dtype("int32") | ||
| expected_ds = open_dataset(simple_netcdf4) | ||
| expected_array = expected_ds["foo"].to_numpy() | ||
| npt.assert_equal(pres_array, expected_array) |
There was a problem hiding this comment.
This can also all be checked by doing open_zarr then using a single xarray assertion. But it might be valuable to keep these lower-level assertions too.
|
Also add a note to |
Co-authored-by: Tom Nicholas <[email protected]>
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
There is some weirdness when comparing the icechunk datasets using the testing tools that dont happen if you check the individual peices of the dataset. Leaving further refinement for another PR |
mpiannucci
temporarily deployed
to
test-release
GitHub Actions
Inactive
|
So psyched for this!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to write to an Icechunk store. Co developed with @TomNicholas.
See earth-mover/VirtualiZarr#1 for more information (ported from that branch)
docs/releases.rstapi.rst