Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not skip hooks when diffing, conforming, etc #181

Merged
merged 1 commit into from
Apr 1, 2024
Merged

do not skip hooks when diffing, conforming, etc #181

merged 1 commit into from
Apr 1, 2024

Conversation

djeebus
Copy link
Collaborator

@djeebus djeebus commented Apr 1, 2024

this behavior causes confusion and kubechecks loses some value in not checking these

@djeebus
do not skip hooks
fc8e192 
causes confusion and kubechecks loses some value in not checking these

Signed-off-by: Joseph Lombrozo <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Temporary image deleted.

polyrain
polyrain approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@polyrain polyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, minimising confusion and bringing kc's behaviour closer to what you'd expect is a 👍 to me.

@djeebus djeebus merged commit 14e5941 into main Apr 1, 2024
5 checks passed
@djeebus djeebus deleted the stop-skipping-hooks branch April 1, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polyrain polyrain polyrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djeebus @polyrain