fix test

Signed-off-by: AvivGuiser <[email protected]>
zapier · Oct 3, 2024 · ade1c76 · ade1c76
1 parent 934054c
commit ade1c76
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/pkg/vcs/github_client/client.go b/pkg/vcs/github_client/client.go
@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"net/url"
 	"regexp"
 	"strconv"
 	"strings"
@@ -193,8 +192,7 @@ func (c *Client) buildRepoFromComment(context context.Context, comment *github.I
 	owner := comment.GetIssue().GetRepository().GetOwner().GetName()
 	repo := comment.GetIssue().GetRepository().GetName()
 	prNumber := comment.GetIssue().GetNumber()
-	if err != nil {
-		log.Error().Msgf("failed to convert prNumber: %s", err)
+	if prNumber == 0 || repo == "" || owner == "" {
 		return nilPr
 	}
 	pr, ghStatus, err := c.googleClient.PullRequests.Get(context, owner, repo, prNumber)

diff --git a/pkg/vcs/github_client/client_test.go b/pkg/vcs/github_client/client_test.go
@@ -394,7 +394,14 @@ func TestClient_buildRepoFromComment(t *testing.T) {
 				context: context.TODO(),
 				comment: &github.IssueCommentEvent{
 					Issue: &github.Issue{
-						URL: github.String("https://github.com/zapier/kubechecks/pull/250"),
+						URL:    github.String("https://github.com/zapier/kubechecks/pull/250"),
+						Number: github.Int(250),
+						Repository: &github.Repository{
+							Name: github.String("prguy"),
+							Owner: &github.User{
+								Name: github.String("zapier;"),
+							},
+						},
 					},
 					Repo: &github.Repository{
 						DefaultBranch: github.String("main"),
@@ -488,9 +495,7 @@ func TestClient_buildRepoFromComment(t *testing.T) {
 			args: args{
 				context: context.TODO(),
 				comment: &github.IssueCommentEvent{
-					Issue: &github.Issue{
-						URL: nil,
-					},
+					Issue: nil,
 					Repo: &github.Repository{
 						DefaultBranch: github.String("main"),
 						Name:          github.String("prguy"),